Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commitlog_replayer uses local var reference in continuation #4187

Closed
elcallio opened this Issue Feb 4, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@elcallio
Copy link
Contributor

elcallio commented Feb 4, 2019

In the collection (map reduce) of replay_positions per CF, local var "uuid" is ref:ed in a continuation.

Works 99.9% of the time because the continuation is not actually delayed (and assuming we begin the
checks with non-truncated (system) cf:s it works).
But if we do delay continuation, the resulting cf map will be borked.

avikivity added a commit that referenced this issue Feb 4, 2019

commitlog_replayer: Bugfix: finding truncation positions uses local v…
…ar ref

"uuid" was ref:ed in a continuation. Works 99.9% of the time because
the continuation is not actually delayed (and assuming we begin the
checks with non-truncated (system) cf:s it works).
But if we do delay continuation, the resulting cf map will be
borked.

Fixes #4187.

Message-Id: <20190204141831.3387-1-calle@scylladb.com>
(cherry picked from commit 9cadbaa)

avikivity added a commit that referenced this issue Feb 4, 2019

commitlog_replayer: Bugfix: finding truncation positions uses local v…
…ar ref

"uuid" was ref:ed in a continuation. Works 99.9% of the time because
the continuation is not actually delayed (and assuming we begin the
checks with non-truncated (system) cf:s it works).
But if we do delay continuation, the resulting cf map will be
borked.

Fixes #4187.

Message-Id: <20190204141831.3387-1-calle@scylladb.com>
(cherry picked from commit 9cadbaa)

avikivity added a commit that referenced this issue Feb 4, 2019

commitlog_replayer: Bugfix: finding truncation positions uses local v…
…ar ref

"uuid" was ref:ed in a continuation. Works 99.9% of the time because
the continuation is not actually delayed (and assuming we begin the
checks with non-truncated (system) cf:s it works).
But if we do delay continuation, the resulting cf map will be
borked.

Fixes #4187.

Message-Id: <20190204141831.3387-1-calle@scylladb.com>
(cherry picked from commit 9cadbaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.