Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement abstract_type::to_string() for all types. #4633

Closed
haaawk opened this issue Jul 2, 2019 · 1 comment

Comments

@haaawk
Copy link
Member

commented Jul 2, 2019

Large cell/row detector prints out values of cells and when to_string() for a type is not implemented it crashes.

@slivne slivne added this to the 3.2 milestone Jul 2, 2019

kbr- added a commit to kbr-/scylla that referenced this issue Jul 3, 2019

Implement tuple_type_impl::to_string_impl.
Resolves scylladb#4633.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

kbr- added a commit to kbr-/scylla that referenced this issue Jul 3, 2019

Implement tuple_type_impl::to_string_impl.
Resolves scylladb#4633.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

kbr- added a commit to kbr-/scylla that referenced this issue Jul 3, 2019

Implement tuple_type_impl::to_string_impl.
Resolves scylladb#4633.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

avikivity added a commit that referenced this issue Jul 3, 2019

Implement tuple_type_impl::to_string_impl. (#4645)
Resolves #4633.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

avikivity added a commit that referenced this issue Jul 4, 2019

Implement tuple_type_impl::to_string_impl. (#4645)
Resolves #4633.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

avikivity added a commit that referenced this issue Jul 8, 2019

Implement tuple_type_impl::to_string_impl. (#4645)
Resolves #4633.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>
(cherry picked from commit 8995945)

avikivity added a commit that referenced this issue Jul 8, 2019

Implement tuple_type_impl::to_string_impl. (#4645)
Resolves #4633.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>
(cherry picked from commit 8995945)
@avikivity

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

Already backported, removing label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.