Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marshalling error of date in Scylla, works in Cassandra #4641

Closed
tzach opened this issue Jul 3, 2019 · 2 comments

Comments

@tzach
Copy link
Contributor

commented Jul 3, 2019

Scylla version (or git commit hash): 3.0.8
OS (RHEL/CentOS/Ubuntu/AWS AMI): Docker

The following work with Cassandra 3.11 but not Scylla

cqlsh> CREATE KEYSPACE mykeyspace WITH replication = {'class': 'SimpleStrategy', 'replication_factor' : 1};
cqlsh> use mykeyspace ;
cqlsh:mykeyspace> CREATE TABLE test_date (a timestamp primary key); 
cqlsh:mykeyspace> INSERT INTO test_date (a) VALUES ('2019-07-02T18:50:10Z');
INSERT INTO test_date (a) VALUES ('2019-07-02T18:50:10Z'); 
InvalidRequest: Error from server: code=2200 [Invalid query] message="marshaling error: unable to parse date '2019-07-02T18:50:10Z': marshaling error: Unable to parse timezone 'z'"

Note the Z in the date is reported is in low case, altho the input is upper case
Cassandra does not accept low case either.

@tzach

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

@slivne slivne added this to the 3.2 milestone Jul 7, 2019

@slivne slivne added the Backport 3.1 label Jul 7, 2019

kbr- added a commit to kbr-/scylla that referenced this issue Jul 8, 2019

Fix timestamp_type_impl::timestamp_from_string.
Now it accepts the 'z' or 'Z' timezone, denoting UTC+00:00.
Fixes scylladb#4641.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

kbr- added a commit to kbr-/scylla that referenced this issue Jul 9, 2019

Fix timestamp_type_impl::timestamp_from_string.
Now it accepts the 'z' or 'Z' timezone, denoting UTC+00:00.
Fixes scylladb#4641.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

@slivne slivne added the Backport 3.0 label Jul 17, 2019

kbr- added a commit to kbr-/scylla that referenced this issue Jul 17, 2019

Accept the 'z' and 'Z' timezone in timestamp_from_string.
The 'z' (or 'Z') timezone denotes UTC+00:00.
Fixes scylladb#4641.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

kbr- added a commit to kbr-/scylla that referenced this issue Jul 17, 2019

Accept the 'z' and 'Z' timezone in timestamp_from_string.
The 'z' (or 'Z') timezone denotes UTC+00:00.
Fixes scylladb#4641.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>

avikivity added a commit that referenced this issue Jul 17, 2019

Fix timestamp_type_impl::timestamp_from_string.
Now it accepts the 'z' or 'Z' timezone, denoting UTC+00:00.
Fixes #4641.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>
(cherry picked from commit 4417e78)

avikivity added a commit that referenced this issue Jul 17, 2019

Fix timestamp_type_impl::timestamp_from_string.
Now it accepts the 'z' or 'Z' timezone, denoting UTC+00:00.
Fixes #4641.

Signed-off-by: Kamil Braun <kbraun@scylladb.com>
(cherry picked from commit 4417e78)
@slivne

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

This was released in 3.0.9 and will be part of 3.1.0

@tzach tzach modified the milestones: 3.2, 3.1 Jul 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.