Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commitlog pre-fill inner loop condition broken (again) #8369

Closed
elcallio opened this issue Mar 29, 2021 · 0 comments
Closed

Commitlog pre-fill inner loop condition broken (again) #8369

elcallio opened this issue Mar 29, 2021 · 0 comments

Comments

@elcallio
Copy link
Contributor

This was originally found (and fixed) by @gleb-cloudius , but the patch set with the fix was reverted at some point, and the fix went away. Now the error remains even in new, nice coroutine code.

We check the wrong var in the inner loop of the pre-fill path of allocate_segment_ex, often causing us to generate giant writev:s of more or less the whole file. Not intended.

elcallio pushed a commit to elcallio/scylla that referenced this issue Mar 29, 2021
Fixes scylladb#8369

This was originally found (and fixed) by @gleb-cloudius, but the patch set with the
fix was reverted at some point, and the fix went away. Now the error remains even
in new, nice coroutine code.

We check the wrong var in the inner loop of the pre-fill path of allocate_segment_ex,
often causing us to generate giant writev:s of more or less the whole file.
Not intended.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants