Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gossip: add local application state excess logging #8616

Closed
eliransin opened this issue May 10, 2021 · 0 comments
Closed

gossip: add local application state excess logging #8616

eliransin opened this issue May 10, 2021 · 0 comments
Assignees
@eliransin
Milestone
4.6

Comments

@eliransin
Copy link
Contributor

The function gossiper::add_local_application_state has an excess logging which is both, pollutes the log and has
and excess severity. The function logs and error and throws the same error as an exception just to catch it few lines below
and log it as a warning.
I propose to remove the error loging prior to throwing the exception in order to allow future exception propagation if this
is desired.
eliransin pushed a commit to eliransin/scylla that referenced this issue May 10, 2021
gossiper: remove excess error logging from gossiper
eb6a785 
We remove a log of severity error that is later thrown as an
exception, being catched few lines below and then printed out as
a warning.

Fixes scylladb#8616
@eliransin eliransin mentioned this issue May 10, 2021
Closed
@eliransin eliransin self-assigned this May 10, 2021
@DoronArazii DoronArazii added this to the 4.6 milestone May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliransin eliransin

Labels
None yet
Projects
None yet
Milestone
4.6
Development

Successfully merging a pull request may close this issue.

Handle excess logging of non existing local endpoint eliransin/scylla
4 participants
@mykaul @eliransin @scylladb-promoter @DoronArazii