-
Notifications
You must be signed in to change notification settings - Fork 1.6k
TLS: support for extracting certificate subject alt names from client certs #1629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks good, but please elaborate on "Initially we don't include this in accept-sequence auth verification, though we maybe should include it as an option.". What does that mean? That we should accept some predicate to apply to alt names? |
It means that we should maybe add it as an (optional), retrievable attribute for the I was thinking something like:
to maintain compatibility. |
9cf7d7d
to
9f1f930
Compare
ping? |
Fixes scylladb#1628 Subject alt name info can contain more extensive and detailed info on a connecting client. Add interface to allow querying this from a connected socket. Initially we don't include this in accept-sequence auth verification, though we maybe should include it as an option in `set_dn_verification_callback`.
For printing. And consequential parsing/matching. Note: because naming of alternative names is inconsistent between tools, and because openssl is probably more popular when creating certs anyway, this routine will be inconsistent with both gnutls and openssl (though more in line with the latter) and name the constants as follows: * dnsname: "DNS" * rfc822name: "EMAIL" * uri: "URI" * ipaddress "IP" * othername: "OTHERNAME" * dn: "DIRNAME"
ping? |
Fixes #1628
Subject alt name info can contain more extensive and detailed info on a connecting client. Add interface to allow querying this from a connected socket.
Initially we don't include this in accept-sequence auth verification, though we maybe should include it as an option.