TLS: support for extracting certificate subject alt names from client certs#1629
Merged
Conversation
avikivity
reviewed
Apr 25, 2023
avikivity
reviewed
Apr 25, 2023
avikivity
reviewed
Apr 25, 2023
Member
|
Looks good, but please elaborate on "Initially we don't include this in accept-sequence auth verification, though we maybe should include it as an option.". What does that mean? That we should accept some predicate to apply to alt names? |
Contributor
Author
|
It means that we should maybe add it as an (optional), retrievable attribute for the I was thinking something like: to maintain compatibility. |
9cf7d7d to
9f1f930
Compare
Contributor
Author
|
ping? |
added 3 commits
May 2, 2023 12:16
Fixes scylladb#1628 Subject alt name info can contain more extensive and detailed info on a connecting client. Add interface to allow querying this from a connected socket. Initially we don't include this in accept-sequence auth verification, though we maybe should include it as an option in `set_dn_verification_callback`.
For printing. And consequential parsing/matching. Note: because naming of alternative names is inconsistent between tools, and because openssl is probably more popular when creating certs anyway, this routine will be inconsistent with both gnutls and openssl (though more in line with the latter) and name the constants as follows: * dnsname: "DNS" * rfc822name: "EMAIL" * uri: "URI" * ipaddress "IP" * othername: "OTHERNAME" * dn: "DIRNAME"
Contributor
Author
|
ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1628
Subject alt name info can contain more extensive and detailed info on a connecting client. Add interface to allow querying this from a connected socket.
Initially we don't include this in accept-sequence auth verification, though we maybe should include it as an option.