Subclass Assumptions Predicate from FOL

[sd-biswas]

• Subclass assumptions.Predicate from FOL.Callable and rename it to AssumptionsPredicate.
• Subclass assumptions.AppliedPredicate from FOL.Applied and rename it to AppliedAssumptionsPredicate.
• Rename Function and AppliedFunction in FOL.

[asmeurer]

Can you enable Travis CI on you fork so that the tests run here?

[sd-biswas]

Ask is completely screwed up at this moment. But before I get down to the messy business I want to confirm that this is exactly what you want, then I'll fix the issues.

[asmeurer]

I want you to enable Travis so I can see what is going wrong.

[asmeurer]

I thought your class was called Predicate

[sd-biswas]

It is called Predicate. But the logic behind Predicate is in Callable and similarly logic behind AppliedPredicate is in Applied. FOL Predicate subclasses Callable and overrides the apply() method. Subclassing Predicate will produce the exact same result. So it is simply a question of preference.

[asmeurer]

I would subclass Predicate. That seems clearer, and assumedly its apply would be useful here.

[sd-biswas]

Yeah, I did. But I think it will probably start running after I make a commit (I'll dummy one now and later rebase it out).

[asmeurer]

This looks like it is the right idea.