Migrate aggregated APIService TLS from hardcoded Secret to cert-manager#447
Open
alexandernorth wants to merge 3 commits into
Open
Migrate aggregated APIService TLS from hardcoded Secret to cert-manager#447alexandernorth wants to merge 3 commits into
alexandernorth wants to merge 3 commits into
Conversation
steiler
reviewed
May 20, 2026
| @@ -1 +1,33 @@ | |||
| kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.16.2/cert-manager.yaml No newline at end of file | |||
| # cert-manager | |||
Contributor
There was a problem hiding this comment.
do we still need this file? the install docs shows cert-manager clearly as a prereq.
The scripts there do also wait for cert-manager to become ready.
I do howver agree that we need to document the trust chain down there somewhere. Docs repo?
Contributor
Author
There was a problem hiding this comment.
I will add it to the docs, but I don't see the harm in having it here too, or is the goal of this section something else?
Contributor
Author
There was a problem hiding this comment.
I have added it to the docs with this PR sdcio/docs#141
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #76.
Summary
Replace the hardcoded
api-server-certSecret with a cert-manager-issued cert chain following the SelfSigned bootstrapping pattern. RemovesinsecureSkipTLSVerify: trueon theAPIService.caBundleis now populated bycainjectorfrom the CA Certificate.Chain:
selfsigned-cluster-issuer->sdc-ca(CA) ->sdc-ca-issuer->api-server-cert(mounted by the api-server Deployment, same Secret name as before).Prerequisites
cainjectorReady.artifacts/certmanager/install.md.