Add and install PAM services for FreeBSD. #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How likely is it that the PAM files will diverge from upstream in the future? For Linux distros this is rather likely and so those should probably be handled downstream, for FreeBSD I don't know. |
|
I don't quite get what you mean. I'm coming from downstream with this change so that we don't have to patch SDDM pam files to fit our needs. |
|
I'm asking how likely it is that you'll have to edit the PAM files from upstream again soon because some changes were made, like pam module addition, rename, removal or option changes. |
|
If this PR gets merged in then it's quite unlikely. We're using these PAM services for years now. |
|
Ok. In that case we can take them as-is IMO. |
Vogtinator
approved these changes
Jul 27, 2023
alebastr
reviewed
Jul 27, 2023
Sponsored by: Serenity Cybersecurity, LLC
Vogtinator
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.