Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never try to login as the user SDDM #279

Merged
merged 1 commit into from Oct 6, 2014

Conversation

@davidedmundson
Copy link
Member

@davidedmundson davidedmundson commented Oct 2, 2014

No description provided.

@plfiorini
Copy link
Member

@plfiorini plfiorini commented Oct 2, 2014

looks a very welcome patch

Loading

@jleclanche
Copy link
Member

@jleclanche jleclanche commented Oct 2, 2014

You're hardcoding sddm even though the user/group is customizable by the distro. Risky.

Loading

@davidedmundson
Copy link
Member Author

@davidedmundson davidedmundson commented Oct 2, 2014

so does PamBackend::start
though maybe that's wrong too, and should be replaced with an explicit --greeter argument.

Loading

@plfiorini
Copy link
Member

@plfiorini plfiorini commented Oct 2, 2014

As far as I remember we only accept a user named sddm.

Loading

@davidedmundson
Copy link
Member Author

@davidedmundson davidedmundson commented Oct 2, 2014

New version uses explicit flag instead of username comparison

Loading

@MartinBriza
Copy link
Contributor

@MartinBriza MartinBriza commented Oct 2, 2014

I'd leave out blocking the "sddm" user... it could cause only minor problems to folks who already have a regular user called like that... if there are any at all. Not insisting though

Loading

@jleclanche
Copy link
Member

@jleclanche jleclanche commented Oct 2, 2014

@MartinBriza That is a broken setup in our regard if they have a user the same as the sddm user.

Loading

MartinBriza added a commit that referenced this issue Oct 6, 2014
Never try to login as the user SDDM
@MartinBriza MartinBriza merged commit 6266850 into sddm:master Oct 6, 2014
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants