should there be a problem with the sddm user, be more verbose instead of normal exit #397

Merged
merged 1 commit into from Apr 4, 2015

Conversation

Projects
None yet
2 participants
Contributor

mathieujobin commented Apr 4, 2015

fix in relation to issue #371

print verbose messages in case there is a problem with sddm user.
also, do failure exit instead of normal exit

cheers,

src/helper/UserSession.cpp
- bail(2);
- if (chdir(pw->pw_dir) != 0)
- bail(2);
+ //TODO: why do we need to fetch the info from the passwd file?
@davidedmundson

davidedmundson Apr 4, 2015

Owner

Remove this line.
Code is not a bug tracker

Owner

davidedmundson commented Apr 4, 2015

Looks good. Make that one change I want and I'll merge this.

Thanks.

Contributor

mathieujobin commented Apr 4, 2015

i removed that comment and fix a syntax error I had.

Owner

davidedmundson commented Apr 4, 2015

Thanks very much.

@davidedmundson davidedmundson reopened this Apr 4, 2015

davidedmundson added a commit that referenced this pull request Apr 4, 2015

Merge pull request #397 from mathieujobin/helper_verbose_exit
Should there be a problem with the sddm user, be more verbose instead of normal exit

@davidedmundson davidedmundson merged commit 9fa9177 into sddm:master Apr 4, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@mathieujobin mathieujobin deleted the mathieujobin:helper_verbose_exit branch Apr 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment