Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_utc() returns False when parsing from a UTC date #295

Conversation

redlickigrzegorz
Copy link
Contributor

@redlickigrzegorz redlickigrzegorz commented Oct 27, 2018

It is a pull request for resolving the problem of is_utc() method -> #293
I created additional two assertions and prepare the code which resolves the problem without the breaking anything else, I hope.
Furthermore, I think that this method should return True for "GMT" timezone because there is no time difference between Greenwich Mean Time and Coordinated Universal Time.

@redlickigrzegorz redlickigrzegorz force-pushed the bugfix/293-is_utc_returns_false_when_parsing_from_a_utc_date branch from 06413e0 to 3b85cee Compare Oct 30, 2018
joaonc
joaonc approved these changes Nov 10, 2018
Copy link

@joaonc joaonc left a comment

Changes look good. Hope this gets merged soon.

Copy link

@dazza-codes dazza-codes left a comment

LGTM

@redlickigrzegorz
Copy link
Contributor Author

redlickigrzegorz commented Feb 26, 2019

@sdispater What do you think about my solution? Is it a good idea to think about the merge to resolve the problem?

@sdispater sdispater merged commit 504c78c into sdispater:master Mar 6, 2020
3 checks passed
@sdispater
Copy link
Owner

sdispater commented Mar 6, 2020

Thanks for your contribution!

@sdispater sdispater mentioned this pull request Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants