Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_birthday should be is_anniversary #298

Conversation

redlickigrzegorz
Copy link
Contributor

@redlickigrzegorz redlickigrzegorz commented Oct 28, 2018

It is a pull request for implementing an alias for is_birthday() method -> #272

@redlickigrzegorz redlickigrzegorz force-pushed the feature/272-is_birthday_should_be_is_anniversary branch from 7c76ddc to a4033b7 Compare Oct 30, 2018
pendulum/date.py Outdated Show resolved Hide resolved
pendulum/datetime.py Show resolved Hide resolved
@redlickigrzegorz
Copy link
Contributor Author

redlickigrzegorz commented Feb 26, 2019

@sdispater What do you think about my solution? Is it a good idea to think about the merge to resolve the problem?

@jamesmyatt
Copy link

jamesmyatt commented May 27, 2019

Good enough for me, but I'm not a contributor

@sdispater sdispater merged commit cbcebfb into sdispater:master Mar 6, 2020
3 checks passed
@sdispater sdispater mentioned this pull request Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants