Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle transition.previous being None #321

Merged
merged 1 commit into from Mar 6, 2020

Conversation

bryanforbes
Copy link
Contributor

@bryanforbes bryanforbes commented Nov 30, 2018

This PR is pretty simplistic, but I found these issues when I was doing the typing updates. pendulum.tz.zoneinfo.Transition.previous can be None and mypy was flagging it, so I added guards for that condition and a test for America/Chicago for 1883-11-18.

@sdispater sdispater merged commit fb2b950 into sdispater:master Mar 6, 2020
@sdispater
Copy link
Owner

sdispater commented Mar 6, 2020

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants