Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for an issue that gvm-init doesn't load gvm modules when it is executed from another script #159

Merged
merged 3 commits into from May 3, 2013

Conversation

@masatonagai
Copy link
Contributor

commented May 3, 2013

"source ~/.gvm/bin/gvm-init.sh" in another shell script doesn't load the gvm modules if $GVM_INIT of the login shell is true. This fix is to load the gvm modules also in that case.

@marc0der

This comment has been minimized.

Copy link
Member

commented May 3, 2013

This fixes issue #155, which people using login shells seem to be having. I'll try deploying it soon.

Thanks for the great work!

marc0der pushed a commit that referenced this pull request May 3, 2013
Marco Vermeulen
Merge pull request #159 from masatonagai/master
Fix for an issue that gvm-init doesn't load gvm modules when it is executed from another script

@marc0der marc0der merged commit 37a1d28 into sdkman:master May 3, 2013

@marc0der

This comment has been minimized.

Copy link
Member

commented May 3, 2013

Need to reopen since your change has broken many tests. Please see here.
https://drone.io/github.com/gvmtool/gvm/latest

@masatonagai

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2013

The tests have been failed before. Please try "git checkout d71f536 && ./gradlew".

@marc0der

This comment has been minimized.

Copy link
Member

commented May 3, 2013

The tests were definitely green before I pulled in your changes, I checked before pulling.

It looks like we have a regression around the aeroplane mode, and the gradle install task is also broken. I've just fixed the gradle build and will look into why all the tests are failing.

It's probably something small ;-)

@marc0der

This comment has been minimized.

Copy link
Member

commented May 3, 2013

Okay, we're all green again! https://drone.io/github.com/gvmtool/gvm/19

I'll deploy it to the test environment for you to have a play with before pushing it live.

Simply do the following:

$ export GVM_SERVICE="test.gvmtool.net"
$ gvm selfupdate

The broadcast message will appear old, but if you type gvm version you should see 1.0.4. Then open a new console and run your benchmarks.

Let me know how it goes and if you're happy I will release to prod!

@masatonagai

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2013

Thank you for merging! I found another problem. I'll send you a pull request.

masatonagai added a commit to masatonagai/gvm that referenced this pull request May 3, 2013
additional fix for sdkman#159
declare necessary variables before load sub-modules

move declarations are back to gvm-init.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.