Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterator interface for picks, and minor code cleanup. #1

Merged
merged 6 commits into from Mar 15, 2017

Conversation

@jswrenn
Copy link
Contributor

jswrenn commented Mar 15, 2017

This pull requests implements IntoIterator for &AliasTable, and introduces AliasTableIterator (which implements Iterator).

A few minor code-smells are corrected, too:

  • replaced two multi-line routines with more succinct calls to standard-library functions (namely extend)
  • replaced the num dependency with num_traits, the only subset of num that was used
  • made clippy happy

I use the pick iterator here.

@sdleffler

This comment has been minimized.

Copy link
Owner

sdleffler commented Mar 15, 2017

Nice work! Thanks for the PR.

@sdleffler sdleffler merged commit 32711cc into sdleffler:master Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.