Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix #27

Merged
merged 1 commit into from Aug 2, 2019

Conversation

@Exlsunshine
Copy link
Contributor

commented Aug 2, 2019

Fix calling convert_sklearn

Bug fix
Fix calling convert_sklearn
@sdpython

This comment has been minimized.

Copy link
Owner

commented Aug 2, 2019

Which version of sklearn-onnx are you using? The version from master branch shoud be working. The version on pypi is too old but should be updated soon.

@sdpython

This comment has been minimized.

Copy link
Owner

commented Aug 2, 2019

I think the best would be to try catch the first call with dtype and then to fallback to the second call without if it fails.

@sdpython sdpython merged commit 83f0f14 into sdpython:master Aug 2, 2019
0 of 5 checks passed
0 of 5 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
sdpython.mlprodict Build #20190802.1 had test failures
Details
sdpython.mlprodict (TestLinux Python37-Linux) TestLinux Python37-Linux failed
Details
sdpython.mlprodict (TestMac Python37-Mac) TestMac Python37-Mac failed
Details
@Exlsunshine

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

Which version of sklearn-onnx are you using? The version from master branch shoud be working. The version on pypi is too old but should be updated soon.

1.5.0

@Exlsunshine

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2019

I think the best would be to try catch the first call with dtype and then to fallback to the second call without if it fails.

Yes, adding a try catch is better, maybe I was using an old version of skl-onnx and then I encountered the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.