From c7775a884e12fd31ce200ab8077b2656dd5d387d Mon Sep 17 00:00:00 2001 From: xadupre Date: Thu, 25 Sep 2025 18:51:55 +0200 Subject: [PATCH 1/2] Fix --patch argument --- onnx_diagnostic/_command_lines_parser.py | 5 +++-- onnx_diagnostic/torch_models/validate.py | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/onnx_diagnostic/_command_lines_parser.py b/onnx_diagnostic/_command_lines_parser.py index 2eefda5d..2c6f72b1 100644 --- a/onnx_diagnostic/_command_lines_parser.py +++ b/onnx_diagnostic/_command_lines_parser.py @@ -581,6 +581,7 @@ def _cmd_validate(argv: List[Any]): ): print(f"validate - unsupported args: export={args.export!r}, opt={args.opt!r}") return + patch_dict = args.patch if isinstance(args.patch, dict) else {"patch": args.patch} summary, _data = validate_model( model_id=args.mid, task=args.task, @@ -591,8 +592,8 @@ def _cmd_validate(argv: List[Any]): use_pretrained=args.trained, dtype=args.dtype, device=args.device, - patch=args.patch, - rewrite=args.rewrite, + patch=patch_dict, + rewrite=args.rewrite and patch_dict.get("patch", True), stop_if_static=args.stop_if_static, optimization=args.opt, exporter=args.export, diff --git a/onnx_diagnostic/torch_models/validate.py b/onnx_diagnostic/torch_models/validate.py index e2c5b9ec..8375ce94 100644 --- a/onnx_diagnostic/torch_models/validate.py +++ b/onnx_diagnostic/torch_models/validate.py @@ -412,7 +412,7 @@ def validate_model( assert not rewrite or patch_kwargs.get("patch", False), ( f"rewrite={rewrite}, patch={patch}, patch_kwargs={patch_kwargs} " f"patch must be True to enable rewriting, " - f"if --no-patch was specified on the command line, --no-rewrite must be added." + f"if --patch=0 was specified on the command line, rewrites are disabled." ) summary = version_summary() summary.update( From 9f90853a8624535e549d5447128b980c8ce0ee11 Mon Sep 17 00:00:00 2001 From: xadupre Date: Thu, 25 Sep 2025 18:54:04 +0200 Subject: [PATCH 2/2] doc --- CHANGELOGS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOGS.rst b/CHANGELOGS.rst index 537e7906..d3a2d2bf 100644 --- a/CHANGELOGS.rst +++ b/CHANGELOGS.rst @@ -4,6 +4,8 @@ Change Logs 0.7.12 ++++++ +* :pr:`232`: fixes ``--patch`` argument so that ``--patch=0`` works +* :pr:`231`: better statistics about fusions * :pr:`227`: better support for ``model_id//pretrained``, adds speed up when running command validate * :pr:`226`: fix input order for models created with modelbuilder