fix type issue

sdpython · Nov 9, 2018 · d3231df · d3231df
1 parent 13475d3
commit d3231df
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/_doc/sphinxdoc/source/tutorial/sphinx.rst b/_doc/sphinxdoc/source/tutorial/sphinx.rst
@@ -232,7 +232,7 @@ It looks into the page and adds a link to each local sections.
 *runpython*: execute a script
 +++++++++++++++++++++++++++++
 
-Location: :class:`RunPythonDirective <pyquickhelper.sphinxext.sphinxext_runpython_extension.RunPythonDirective>`.
+Location: :py:class:`RunPythonDirective <pyquickhelper.sphinxext.sphinxext_runpython_extension.RunPythonDirective>`.
 
 In *conf.py*:
 

diff --git a/_unittests/ut_sphinxext/test_downloadlink_extension.py b/_unittests/ut_sphinxext/test_downloadlink_extension.py
@@ -43,7 +43,8 @@ def get_name(self):
         dest = os.path.join(this, name)
         return dest.replace("\\", "/")
 
-    @unittest.skipIf(StrictVersion(sphinx.__version__) < StrictVersion(1.8))
+    @unittest.skipIf(StrictVersion(sphinx.__version__) < StrictVersion('1.8'),
+                     reason="DownloadFiles not available in 1.7")
     def test_downloadlink_rst(self):
         name = self.get_name()
         content = """
@@ -65,7 +66,8 @@ def test_downloadlink_rst(self):
         with open(os.path.join(temp, "out.rst"), "w", encoding="utf8") as f:
             f.write(out)
 
-    @unittest.skipIf(StrictVersion(sphinx.__version__) < StrictVersion(1.8))
+    @unittest.skipIf(StrictVersion(sphinx.__version__) < StrictVersion("1.8"),
+                     reason="DownloadFiles not available in 1.7")
     def test_downloadlink_md(self):
         name = self.get_name()
         content = """
@@ -82,7 +84,8 @@ def test_downloadlink_md(self):
         with open(os.path.join(temp, "out.rst"), "w", encoding="utf8") as f:
             f.write(out)
 
-    @unittest.skipIf(StrictVersion(sphinx.__version__) < StrictVersion(1.8))
+    @unittest.skipIf(StrictVersion(sphinx.__version__) < StrictVersion("1.8"),
+                     reason="DownloadFiles not available in 1.7")
     def test_downloadlink_html(self):
         name = self.get_name()
         content = """