Skip to content
This repository was archived by the owner on Jan 13, 2024. It is now read-only.

Replaces an exception with an logged message #350

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Replaces an exception with an logged message #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af5eb90
Replaces an exception with an logged message
sdpython Oct 4, 2021
37f2883
Merge branch 'master' of https://github.com/sdpython/pyquickhelper in…
sdpython Oct 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/pyquickhelper/sphinxext/sphinx_md_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -977,8 +977,9 @@ def depart_todo_node(self, node):
self.depart_admonition(node)

def unknown_visit(self, node):
raise NotImplementedError(
"Unknown node: '{0}' - '{1}'".format(node.__class__.__name__, node))
logger = logging.getLogger("MdBuilder")
logger.warning("[md] unknown visit node: '{0}' - '{1}'".format(
node.__class__.__name__, node))


class MdBuilder(Builder):
Expand Down
10 changes: 6 additions & 4 deletions src/pyquickhelper/sphinxext/sphinx_rst_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,8 +1097,9 @@ def unknown_visit(self, node):
}:
# due to jupyter_sphinx
return
raise NotImplementedError(
"Unknown node: '{0}' - '{1}'".format(node.__class__.__name__, node))
logger = logging.getLogger("RstBuilder")
logger.warning("[rst] unknown visit node: '{0}' - '{1}'".format(
node.__class__.__name__, node))

def unknown_departure(self, node):
classname = node.__class__.__name__
Expand All @@ -1109,8 +1110,9 @@ def unknown_departure(self, node):
}:
# due to jupyter_sphinx
return
raise NotImplementedError(
"Unknown node: '{0}' - '{1}'".format(node.__class__.__name__, node))
logger = logging.getLogger("RstBuilder")
logger.warning("[rst] unknown depart node: '{0}' - '{1}'".format(
node.__class__.__name__, node))


class _BodyPlaceholder:
Expand Down