Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide product variations (e.g size, ...) in the demo shop #19

Closed
fabarea opened this issue Sep 15, 2019 · 4 comments · Fixed by #23
Closed

Provide product variations (e.g size, ...) in the demo shop #19

fabarea opened this issue Sep 15, 2019 · 4 comments · Fixed by #23
Labels
good first issue Good for newcomers

Comments

@fabarea
Copy link

fabarea commented Sep 15, 2019

First of all, thank you for this nice piece of software. Very inspiring!

Browsing the demo shop, I didn't see where / if you can set a product variation such as size, colours, etc.. besides the quantity. Something like this I have in mind: https://store.gatsbyjs.org/product/dark-deploy-tee

Is it already possible?
If not, how would you implement that feature? (= a few hints about what files to touch)
Is it something that could be added out of the box in the demo shop?

@fabarea fabarea changed the title Provide product variation in the demo shop Provide product variations (e.g size, ...) in the demo shop Sep 15, 2019
@sdras
Copy link
Owner

sdras commented Oct 1, 2019

Yeah, I can do that- it would mean adding a small size chooser that could potentially be a component, and then adding that info to the serverless function. Do you want to try to do it? I can include it if you'd like to see how it's done.

@sdras sdras added the good first issue Good for newcomers label Oct 1, 2019
@fabarea
Copy link
Author

fabarea commented Oct 1, 2019

That would be great. I am actually working on the shop and digging how you can add new lambda functions such as sending notification emails + saving the result in a spreadsheet. It could be out of the scope of this demo shop. I will come back to share my findings nevertheless.

Update: #20

@talkor
Copy link
Contributor

talkor commented Oct 11, 2019

@fabarea I hope you don't mind, I added a simple size picker 😄

Cart page:
Screen Shot 2019-10-11 at 17 04 54

Product page:
Screen Shot 2019-10-11 at 17 05 08

Could be really nice to also add a color picker.

@fabarea
Copy link
Author

fabarea commented Oct 16, 2019

Marvelous! 🥇

@sdras sdras closed this as completed in #23 May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants