Gst-base: fix version for gst_flow_combiner_ref/unref #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please squash both commits together. This also requires changes in gstreamer-rs though. Instead of requiring 1.12.1 for usage of gst_base::FlowCombiner, I'd like to use Do you want to provide a PR for that too? |
|
Yes, I will. I was just wondering how to handle this as Gir wouldn't use the version while generating |
gst_flow_combiner_ref/unref were introduced in gstreamer-1.12.1 but they inherit the `since version` declared for `GstFlowCombiner` which is 1.4.
|
It unfortunately means that the whole type has to be done manually. Thanks! :) |
JayDouglass
pushed a commit
to angeleye/gir-files-rs
that referenced
this pull request
Jan 6, 2022
gst_flow_combiner_ref/unref were introduced in gstreamer-1.12.1 but they inherit the `since version` declared for `GstFlowCombiner` which is 1.4. Fixes sdroege/gstreamer-sys#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gst_flow_combiner_ref/unref were introduced in gstreamer-1.12.1 but they inherit the
since versiondeclared forGstFlowCombinerwhich is 1.4.See also: https://bugzilla.gnome.org/show_bug.cgi?id=788778