Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly handle multiple consecutive `?` characters when doing keys pattern match #186

Merged
merged 1 commit into from May 14, 2020

Conversation

@dpsk
Copy link
Contributor

dpsk commented May 13, 2020

Hello, thanks for this library.

Found out that currently redis_pattern_to_ruby_regex doesn't work as intended

As an example it will transform this pattern "^key-????$" into ^key-.?.?$ instead of ^key-....$

i believe that's also what is going on in this issue #178

@sds
sds approved these changes May 14, 2020
Copy link
Owner

sds left a comment

Thank you for the fix, and for adding tests!

@sds sds added the bug label May 14, 2020
@sds sds merged commit d7d9352 into sds:master May 14, 2020
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.02%) to 98.386%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.