Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing conditional type coercion for zset.add #214

Merged

Conversation

@vincentamoore
Copy link
Contributor

@vincentamoore vincentamoore commented Jul 20, 2021

Redis represents zset scores as floats internally, but mock_redis attempts to coerce zset scores to integers. This coercion prevents certain float values from being used as scores (eg. Float::INFINITY).

This PR removes the conditional type coercion from the zset add method, and instead converts all scores to floats.

@sds sds added the bug label Jul 22, 2021
@sds sds merged commit fc03a07 into sds:master Jul 22, 2021
@sds
Copy link
Owner

@sds sds commented Jul 22, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants