Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre commit hook for fasterer #414

Merged
merged 1 commit into from Aug 18, 2016

Conversation

@morizyun
Copy link
Contributor

@morizyun morizyun commented Aug 13, 2016

This hook is to run fasterer to suggest some speed improvements which you can check in detail at the fast-ruby repo.

I am not good at English, but I will always do my best.
If you have any question or advice, please don't hesitate to tell me. 馃嵒

@morizyun morizyun force-pushed the morizyun:feature/add_pre_commit_hook_for_fasterer branch from 45b6b23 to 999b2e0 Aug 13, 2016
@morizyun morizyun force-pushed the morizyun:feature/add_pre_commit_hook_for_fasterer branch from 999b2e0 to 8928d1d Aug 13, 2016
@sds sds merged commit 8928d1d into sds:master Aug 18, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sds sds added the enhancement label Aug 18, 2016
@morizyun
Copy link
Contributor Author

@morizyun morizyun commented Aug 18, 2016

@sds Thank you very much 馃憤

Fasterer:
enabled: false
description: 'Suggest some speed improvements'
required_executable: 'fasterer'

This comment has been minimized.

@jawshooah

jawshooah Aug 18, 2016
Collaborator

Seems like this should have include: '**/*.rb' since it's Ruby-specific and doesn't require a full repo context like Brakeman does.

This comment has been minimized.

@sds

sds Aug 18, 2016
Owner

Thanks for catching! Addressed in 4d9402b.

This comment has been minimized.

@morizyun

morizyun Aug 18, 2016
Author Contributor

Thanks a lot!

@morizyun morizyun deleted the morizyun:feature/add_pre_commit_hook_for_fasterer branch Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants