Add stylelint to pre-commit hook #521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sds
reviewed
Jan 16, 2018
Owner
sds
left a comment
sds
left a comment
There was a problem hiding this comment.
Thanks for the pull request, @brianbancroft.
Overall this looks fine, but as you mentioned it's missing tests. Good tests for hooks simply ensure that the branches of the hook's logic are executed. In your case, you want to check what happens when:
- The
stylelintcommand returns a zero exit status - The
stylelintcommand returns a non-zero exit status - The
stylelintcommand prints messages (i.e. is your regex working and correctly attributing file name and line number?)
See https://github.com/brigade/overcommit/blob/master/spec/overcommit/hook/pre_commit/scss_lint_spec.rb for an example. Happy to merge once tests are in place. Thanks!
| # Defines the gem version. | ||
| module Overcommit | ||
| VERSION = '0.41.0'.freeze | ||
| VERSION = '0.42.0'.freeze |
Owner
There was a problem hiding this comment.
Let's leave this out for now. We'll update the version when we release the next version. Thanks!
Owner
|
Finished in #590 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following is a basic implementation of StyleLint on the pre-commit hook. It's not quite ready for prime-time as I have two areas I still haven't figured out:
Unexpected outputerror (see screencap 1) (regex. Still looking at it)Screencaps
Bad CSS
Below in another repo, I added the gem locally, and added some gobbedly-gook in the CSS. This is the output:
Good CSS
Here's what it looks like otherwise:
Closes #514 if resolved