From 3f13b5f68d3815812649401c18f6b1d9b1044849 Mon Sep 17 00:00:00 2001 From: Dmitry Sinelnikov Date: Sun, 13 Oct 2019 15:41:47 +0300 Subject: [PATCH] Fix markdown lint errors output #678 --- lib/overcommit/hook/pre_commit/mdl.rb | 6 +++--- spec/overcommit/hook/pre_commit/mdl_spec.rb | 5 +++++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/lib/overcommit/hook/pre_commit/mdl.rb b/lib/overcommit/hook/pre_commit/mdl.rb index 4759936e..56349d72 100644 --- a/lib/overcommit/hook/pre_commit/mdl.rb +++ b/lib/overcommit/hook/pre_commit/mdl.rb @@ -19,9 +19,9 @@ def run json_messages.map do |message| Overcommit::Hook::Message.new( :error, - message[:filename], - message[:line], - message[:description] + message['filename'], + message['line'], + "#{message['filename']}:#{message['line']} #{message['rule']} #{message['description']}" ) end end diff --git a/spec/overcommit/hook/pre_commit/mdl_spec.rb b/spec/overcommit/hook/pre_commit/mdl_spec.rb index e84b52cc..119f9a00 100644 --- a/spec/overcommit/hook/pre_commit/mdl_spec.rb +++ b/spec/overcommit/hook/pre_commit/mdl_spec.rb @@ -25,6 +25,7 @@ context 'when mdl exits unsuccessfully' do let(:success) { false } + let(:message) { subject.run.last } context 'and it reports an error' do let(:stdout) do @@ -34,6 +35,9 @@ let(:stderr) { '' } it { should fail_hook } + it { expect(message.file).to eq 'file1.md' } + it { expect(message.line).to eq 1 } + it { expect(message.content).to eq 'file1.md:1 MD013 Line length' } end context 'when there is an error running mdl' do @@ -41,6 +45,7 @@ let(:stderr) { 'Some runtime error' } it { should fail_hook } + it { expect(message).to eq 'Some runtime error' } end end end