Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpaceAfterComment Linter #825

Closed

Conversation

@ivantsepp
Copy link
Contributor

ivantsepp commented Aug 16, 2016

Adds a linter for #813.

This is a big PR (alot of it is tests) so definitely let me know what changes you would like to see in order to get this merged! (or if it should be merged at all).

The basic idea is to look at comment nodes and depending on the type, we do different things.

  • If it's :silent, we need to split by new lines since sass will combine consecutive comments // into one node. There is also an option to allow empty // comments.
  • If it's :normal, count the spaces after /*
  • If it's :loud, count the spaces after /*!
@ivantsepp ivantsepp force-pushed the ivantsepp:add_space_after_comment_linter branch from c51e441 to 8f56a3c Aug 17, 2016
@sds sds added the enhancement label Aug 18, 2016
@sds
Copy link
Owner

sds commented Aug 18, 2016

Thanks for the detailed pull request, @ivantsepp.

Including thorough tests and documentation makes this much easier to 👍

Merged in 21d2444.

@ivantsepp
Copy link
Contributor Author

ivantsepp commented Aug 18, 2016

Thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.