Add SpaceAfterComment Linter #825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantsepp
force-pushed
the
add_space_after_comment_linter
branch
from
c51e441
to
8f56a3c
Compare
|
Thanks for the detailed pull request, @ivantsepp. Including thorough tests and documentation makes this much easier to Merged in 21d2444. |
|
Thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adds a linter for #813.
This is a big PR (alot of it is tests) so definitely let me know what changes you would like to see in order to get this merged! (or if it should be merged at all).
The basic idea is to look at comment nodes and depending on the type, we do different things.
:silent, we need to split by new lines since sass will combine consecutive comments//into one node. There is also an option to allow empty//comments.:normal, count the spaces after/*:loud, count the spaces after/*!