Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opsdb #77

Merged
merged 32 commits into from
Mar 16, 2021
Merged

Opsdb #77

merged 32 commits into from
Mar 16, 2021

Conversation

johndonor3
Copy link
Contributor

I've been tweaking and adding bits to opsdb for awhile now. I don't think this is the final version, but it is working well with Kronos so I think we can consider the core tables fairly stable.

I anticipate some changes in target_to_focal as Mugatu development continues, but I expect those to come from Ilija, so I think it would be nice to merge this branch now. There may also be some other small additions, but no reason to hold up this sizeable merge.

@coveralls
Copy link

coveralls commented Mar 16, 2021

Pull Request Test Coverage Report for Build 429

  • 0 of 115 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
python/sdssdb/peewee/sdss5db/targetdb.py 0 1 0.0%
python/sdssdb/peewee/sdss5db/opsdb.py 0 114 0.0%
Totals Coverage Status
Change from base Build 427: 0.0%
Covered Lines: 0
Relevant Lines: 5470

💛 - Coveralls

Copy link
Member

@albireox albireox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, and no reason not to merge it now, even if it will be further modified later.

The only thing you may want to do, but not really necessary, is to add sdssdb.peewee.sdss5db.opsdb to the list of schemas in peewee/sdss5db/__init__.py. That forces a reload of the module if the database connection changes (for example if one changes the profile or if the database is initially disconnected and then connects). This is really only important for schemas/tables that use reflection or that create models on the fly (for example the CatalogToX models in catalogdb). But I've found that it's useful to have.

@johndonor3 johndonor3 merged commit 5d6dab0 into main Mar 16, 2021
@johndonor3 johndonor3 deleted the opsdb branch March 16, 2021 16:26
@johndonor3 johndonor3 restored the opsdb branch March 16, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants