Jpeg exif #27
Merged
Jpeg exif #27
+160
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some JPEG files might have corrupted Exif tags (or the Exif parsing is flawed, not sure). In any case, FastImage fails on those because the Exif parsing reads beyond the APP1 block.
This PR solves this by reading the APP1 block into a string and parsing the Exif from that string. If the exif parsing fails, no biggie, we continue with the rotation info.
To do this, I gradually isolated the reading into a new
FiberStreamclass and the Exif parsing into its own class. I broke it down into reasonably small commits, each should be reasonably easy to follow.