Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jpeg exif #27

Merged
merged 15 commits into from Jan 29, 2014
Merged

Jpeg exif #27

merged 15 commits into from Jan 29, 2014

Conversation

@marcandre
Copy link
Contributor

marcandre commented Jan 29, 2014

Some JPEG files might have corrupted Exif tags (or the Exif parsing is flawed, not sure). In any case, FastImage fails on those because the Exif parsing reads beyond the APP1 block.

This PR solves this by reading the APP1 block into a string and parsing the Exif from that string. If the exif parsing fails, no biggie, we continue with the rotation info.

To do this, I gradually isolated the reading into a new FiberStream class and the Exif parsing into its own class. I broke it down into reasonably small commits, each should be reasonably easy to follow.

@marcandre marcandre mentioned this pull request Jan 29, 2014
Merged
@sdsykes sdsykes merged commit 8e79e3d into sdsykes:master Jan 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.