Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tax recalculation in certain completed orders #11

Merged
merged 2 commits into from Aug 6, 2019

Conversation

@ashishtajane
Copy link

commented Aug 5, 2019

Order can get recreated (line items and shipments) once it is complete
(e.g. Order Change Tool recreates order completely and it is in complete state with line items and shipments having 0 tax even if order had taxes originally)

This change enables us to recalculate taxes in such cases

@ashishtajane ashishtajane requested a review from joshwines Aug 5, 2019

@ashishtajane ashishtajane force-pushed the jiffy-custom branch from 51ef68c to ea2a2bf Aug 5, 2019

ashishtajane added some commits Aug 5, 2019

Enable tax calculation after order is placed in certain cases
When we use Order Change Tool after order is already placed, all line items
and shipments are recreated
We need to ensure we add correct taxes in this case to the order
This change allows us to do that
Remove condition that disables tax calculation for complete orders
This condition avoids recalculation of taxes if order is complete and current tax is
zero but as per previous commit - such case is possible if we recreate order
using OCT. We do need to recalculate taxes in such cases hence remove this
condition

@ashishtajane ashishtajane force-pushed the jiffy-custom branch from ea2a2bf to 19a706c Aug 6, 2019

@ashishtajane ashishtajane merged commit 33088ec into jiffy-v2.1-v2.2 Aug 6, 2019

@ashishtajane ashishtajane deleted the jiffy-custom branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.