Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document date for Avalara transactions #17

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@ashishtajane
Copy link

commented Sep 11, 2019

It should not be order completed date - but the date when we capture payment which could be upto few days later compared to order completed date - or refund issue date in case of refunds - in correct time zone

@ashishtajane ashishtajane requested a review from joshwines Sep 11, 2019

Fix document date for Avalara transactions
It should not be order completed date - but the date when we capture payment
which could be upto few days later compared to order completed date
`order.doc_date` is being added in main codebase which uses payment
capture dates
Fix document date for Avalara refunds
It is mostly correct. we just need to get the date in the correct timezone
also refactoring to use existing method
Fix tax calculation date after changes to doc date
Now, document date can be a few days after order is placed, but we need to
calculate taxes as per the time order was placed - hence we need to add this
tax override now. It already exists for refund taxes

@ashishtajane ashishtajane force-pushed the fix/doc-date branch from e76c0c0 to ee0f591 Sep 11, 2019

@ashishtajane ashishtajane merged commit fc6cfe1 into jiffy-v2.1-v2.2 Sep 11, 2019

@ashishtajane ashishtajane deleted the fix/doc-date branch Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.