Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous metadata bugs #1026

Closed
amontanez24 opened this issue Sep 22, 2022 · 0 comments · Fixed by #1028
Closed

Miscellaneous metadata bugs #1026

amontanez24 opened this issue Sep 22, 2022 · 0 comments · Fixed by #1028
Assignees
@amontanez24
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@amontanez24
Copy link
Contributor

amontanez24 commented Sep 22, 2022 •
edited

Environment Details

Please indicate the following details about the environment in which you found the bug:

  • SDV version: 1.0.0.dev
  • Python version: Any
  • Operating System: Any

Error Description

The following bugs were found in the SingleTableMetadata class and should be fixed.

  1. constraint_name is removed from metadata after running validate. Validate cannot be run twice because of this.
  2. Boolean columns can be primary keys, but categorical columns cannot. We should also prevent boolean columns.
  3. Extra underscore in error message for primary key type being categorical.
  4. Pii defaults to False instead of True for other sdtypes
  5. Change sdtype physical_address to address
  6. Remove following sdtypes: latitude and longitude
  7. Change representation to computer_representation
@amontanez24 amontanez24 added the bug Something isn't working label Sep 22, 2022
@amontanez24 amontanez24 added this to the 1.0.0 milestone Sep 22, 2022
@amontanez24 amontanez24 mentioned this issue Sep 23, 2022
Merged
@amontanez24 amontanez24 self-assigned this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontanez24 amontanez24

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Miscellaneous metadata bugs sdv-dev/SDV
1 participant
@amontanez24