Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to fix the random seed? #157

Closed
oshev opened this issue Apr 2, 2020 · 2 comments
Closed

No way to fix the random seed? #157

oshev opened this issue Apr 2, 2020 · 2 comments
Labels
feature request Request for a new feature
Milestone

Comments

@oshev
Copy link

oshev commented Apr 2, 2020

  • SDV version: 0.3.2
  • Python version: 3.6.6
  • Operating System: Mac OS Mojave 10.14.6.

Description

I'd like to set up some tests for the generated data in my project but I can't see any way to fix the random seed for the data sampling procedure in SDV. I'm not sure if there is any random factor in data model generation as well so I would need to fix the seed there too.

What I Did

I tried to check the parameters in the methods in SDV - there is nothing about the seed.

I tried to fix the seed using standard Python and Numpy ways:

import numpy as np
import random

RANDOM_SEED = 0

np.random.seed(RANDOM_SEED)
random.seed(RANDOM_SEED)

SDV doesn't get affected by these.

I tried to search for keywords "random" and "seed" in SDV project but I couldn't find anything.

My guess is that randomization comes from some sub-dependencies of the project. I haven't managed to figure out from where exactly yet.

@csala
Copy link
Contributor

csala commented Jul 2, 2020

This might be happening due to how Copulas is handling the random states. See /sdv-dev/Copulas/issues/113

@csala csala added feature request Request for a new feature pending review labels Jul 2, 2020
@csala
Copy link
Contributor

csala commented Jan 21, 2021

Recently introduced models are now properly affected by the numpy and torch seeds, as can be seen in issue #299 , so this can be already closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

4 participants