Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce data constraints #70

Closed
ManuelAlvarezC opened this issue Nov 15, 2018 · 1 comment
Closed

Enforce data constraints #70

ManuelAlvarezC opened this issue Nov 15, 2018 · 1 comment
Labels
feature request Request for a new feature

Comments

@ManuelAlvarezC
Copy link
Contributor

After this issue is solved, we should be ready to enforce data constraints on sampled data.

In order to implement them, they should be checked after data is sampled and reverse_transformed but before is returned. It should be on sdv.Sampler.sample_rows as it's the common access to the process of sampling for the three public methods. The roadmap should be as follows:

1-. Create a method sdv.Sampler.check_constraints that gets a dataframe sampled and reverse transformed and return an array of indices corresponding to rows that fulfill constraints.

2-. Modify the method sdv.Sampler.sample_rows that handles the process of sampling, but before returning the result, checks the data fullfill the constraints, discard the rows that fail and samples again until it gets to the desired number of rows.

@ManuelAlvarezC ManuelAlvarezC added the feature request Request for a new feature label Nov 15, 2018
@ManuelAlvarezC ManuelAlvarezC self-assigned this Nov 15, 2018
@ManuelAlvarezC ManuelAlvarezC added this to the 0.1.2 milestone Apr 25, 2019
@ManuelAlvarezC ManuelAlvarezC modified the milestones: 0.1.2, 0.1.3 May 29, 2019
@csala csala removed this from the 0.1.3 milestone Sep 30, 2019
@csala
Copy link
Contributor

csala commented Jul 23, 2020

A functionality equivalent to this issue was added in #173 , so this can be closed now.

@csala csala closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants