Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Increase encapsulation of UniquePersonList #87

Closed
damithc opened this issue Sep 22, 2016 · 3 comments
Closed

Increase encapsulation of UniquePersonList #87

damithc opened this issue Sep 22, 2016 · 3 comments
Assignees
@AlexLMeow
Labels
a-CodeQuality c.Enhancement p.Medium
Milestone
v1.3

Comments

@damithc
Copy link
Contributor

damithc commented Sep 22, 2016

It's a bit odd to have a getInternalList() method. On the surface it looks like a violation of encapsulation. To be investigated further.
@AlexLMeow AlexLMeow self-assigned this Oct 5, 2016
@AlexLMeow
Copy link
Member

It's there because javafx methods require ObservableLists, we can make ``UniquePersonList` itself implement that interface but that will be a lot of additional boilerplate code for the class. Thoughts?

@damithc
Copy link
Contributor Author

damithc commented Oct 5, 2016

I see. Perhaps rename the method to avoid the word internal? getObservableList()?

@AlexLMeow
Copy link
Member

.asObservableList and probably we can use the UnmodifiableObservableList as the return type

@AlexLMeow AlexLMeow mentioned this issue Oct 19, 2016
Merged
AlexLMeow added a commit that referenced this issue Oct 19, 2016
@AlexLMeow
[#87] Increase encapsulation of UniquePersonList (#162)
a645792 
* renamed method for upl and utl

* fixed storage to use xml adapted tags

* fixed failing tests and RE-ENFORCED CONSTRAINTS PLEASE STOP BREAKING THIS

* trim unused code

* shifted inner classes to bottom
@damithc damithc modified the milestone: v1.3 Oct 19, 2016
Geraldcdx pushed a commit to Geraldcdx/addressbook-level4 that referenced this issue Oct 28, 2018
@jamesyaputra
Merge pull request se-edu#87 from CS2113-AY1819S1-T12-1/WIP-Event-Rem…
c58d3f3 
…inder

[V1.3]WIP Event Reminder
leongshengmin added a commit to leongshengmin/addressbook-level4 that referenced this issue Oct 31, 2018
@leongshengmin
Merge pull request se-edu#87 from leongshengmin/master
c7b16d7 
Add logic to backup WishTransaction each time WishBook is changed
pyokagan pushed a commit to pyokagan/addressbook-level4 that referenced this issue Nov 10, 2019
@huiminlim
Merge pull request se-edu#87 from huiminlim/master
6e4371c 
Added: Multiple Choice randomizer and Checks for no duplicated choices
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AlexLMeow AlexLMeow

Labels
a-CodeQuality c.Enhancement p.Medium
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
2 participants
@damithc @AlexLMeow