Remove function 'get.commit.data' #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rview' Remove the two functions 'get.author.class.activity' and 'get.author.class.activity.overview' from the file 'util-core-peripheral.R'. Signed-off-by: Jakob Kronawitter <kronawij@fim.uni-passau.de>
bockthom
previously requested changes
Apr 17, 2019
Replace 'get.commits' call with a 'get.commits.filtered' call in the function 'get.commit.data' and adjust affected test cases accordingly. This change was made because at each place where 'get.commit.data' is used, it is not wanted that successive calculations work with unfiltered commits. This relates to issue #70. Signed-off-by: Jakob Kronawitter <kronawij@fim.uni-passau.de>
In preparation to the removal of the function 'get.commit.data', remove all calls to this function and replace them with equivalent statements that use the function 'get.commits.filtered'. This relates to issue #70. Signed-off-by: Jakob Kronawitter <kronawij@fim.uni-passau.de>
Remove the function 'get.commit.data' from the file 'util-data.R'. This relates to issue #70. Signed-off-by: Jakob Kronawitter <kronawij@fim.uni-passau.de>
Signed-off-by: Jakob Kronawitter <kronawij@fim.uni-passau.de>
|
I have fixed the two issues in a rebase since this PR is rather small anyways |
clhunsen
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
dev.Description
This pull removes the function
get.commit.dataand replaces calls to this function with simpler statements of equivalent functionality despite that they now use the functionget.commits.filteredto retrieve the filtered commits instead ofget.commitswhich was previously used within the by now deleted functionget.commit.data.Changelog
get.author.class.activityandget.author.class.activity.overviewfrom the fileutil-core-peripheral.R(61b344a)get.commit.datafromutil-data.Rand replace all calls to this function with statements of equivalent functionality despite the fact that they are now retrieving the commit data viaget.commits.filteredinstead ofget.commitswhich was internally used in the functionget.commit.data(486c105, 9194dfc, e259522, Update core-peripheral module #70)