CI: support hardware build and test for PRs #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsf37
reviewed
Jan 27, 2024
lsf37
reviewed
Jan 27, 2024
lsf37
reviewed
Jan 27, 2024
lsf37
approved these changes
Jan 27, 2024
|
Cool, that is definitely useful. I have only minor suggestions (see above). |
Signed-off-by: Axel Heider <axelheider@gmx.de>
This was referenced Jan 27, 2024
Closed
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows hardware build and test via labels
hw-buildandhw-testfor this repo also. So we don't have to ab-use https://github.com/seL4/camkes-vm for hardware test when the actual change and PR is in the examples here. This basically copies things fromcamkes-vm-deploy.yml(but withfail-fast: true) and adapts the label logic from kernel repos.It seems to work, see testing from #59
Could be optimized that the hardware builds don't build
vm_minimal_simon ARMv8, seems thesim: truefromci-actions/camkes-vm/builds.ymlis ignored.This needs seL4/ci-actions#316, otherwise some runs fail because the setting are ignored.