Skip to content

/ getTBinR

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to using ggplot2 in package best practises #77

Closed
seabbs opened this issue Jun 10, 2019 · 2 comments
Closed

Move to using ggplot2 in package best practises #77

seabbs opened this issue Jun 10, 2019 · 2 comments
Assignees
@seabbs
Labels
enhancement good first issue help wanted
Projects
v0.7.0

Comments

@seabbs
Copy link
Owner

@seabbs seabbs commented Jun 10, 2019 •
edited

Based on this post the following best practises need to be implemented.

  • Don't fully import ggplot2, instead import only used functions
  • Switch to using vars(.data[[col]]) rather than aes_string.
  • Make an S3 plot and summary method for TB data (using autoplot).
@seabbs seabbs self-assigned this Jun 10, 2019
@seabbs seabbs added this to To do in v0.7.0 via automation Jun 10, 2019
@seabbs seabbs moved this from To do to In progress in v0.7.0 Sep 3, 2019
@seabbs seabbs mentioned this issue Sep 3, 2019
Open
@seabbs
Copy link
Owner Author

@seabbs seabbs commented Sep 3, 2019

#80 set up to manage develop of s3 method.
@seabbs
Copy link
Owner Author

@seabbs seabbs commented Sep 3, 2019

Done done
@seabbs seabbs closed this Sep 3, 2019
v0.7.0 automation moved this from In progress to Done Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seabbs seabbs

Labels
enhancement good first issue help wanted
Projects
v0.7.0
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@seabbs
You can’t perform that action at this time.