Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to using ggplot2 in package best practises #77

Closed
3 tasks done
seabbs opened this issue Jun 10, 2019 · 2 comments
Closed
3 tasks done

Move to using ggplot2 in package best practises #77

seabbs opened this issue Jun 10, 2019 · 2 comments
Assignees
@seabbs
Labels
enhancement good first issue help wanted

Comments

@seabbs
Copy link
Owner

seabbs commented Jun 10, 2019 •
edited
Loading

Based on this post the following best practises need to be implemented.

  • Don't fully import ggplot2, instead import only used functions
  • Switch to using vars(.data[[col]]) rather than aes_string.
  • Make an S3 plot and summary method for TB data (using autoplot).
@seabbs seabbs self-assigned this Jun 10, 2019
@seabbs seabbs mentioned this issue Sep 3, 2019
Open
@seabbs
Copy link
Owner Author

seabbs commented Sep 3, 2019

#80 set up to manage develop of s3 method.

@seabbs
Copy link
Owner Author

seabbs commented Sep 3, 2019

Done done

@seabbs seabbs closed this as completed Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seabbs seabbs

Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seabbs