Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

best.filter.notch 2 #8

Closed
fribalet opened this issue Oct 28, 2014 · 1 comment
Closed

best.filter.notch 2 #8

fribalet opened this issue Oct 28, 2014 · 1 comment
Assignees
@ctberthiaume
Labels
bug

Comments

@fribalet
Copy link
Contributor

From Maria Hamilton, looking at CMOP_6 dataset
"best.filter.notch will not work for file 3960 but works for 3961, 3959, 4000, 4400, 3900 (all the others I've tried today so far)."
October 24, 2014
@fribalet fribalet added the bug label Oct 28, 2014
@fribalet fribalet changed the title best.filter.notch best.filter.notch 2 Oct 28, 2014
@ctberthiaume ctberthiaume self-assigned this Oct 28, 2014
@ctberthiaume
Copy link
Contributor

Fixed in 91b2ee6. In previous code it was possible for no notch to meet the "best" criteria, leading to the error seen in this issue. Now a notch is always chosen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctberthiaume ctberthiaume

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctberthiaume @fribalet