Question on extensions

[DaveTheMatcher]

I noticed that if there are multiple AudioFormats for audio download, not all formats get to a .m4a file, but some get to a .weba file.
Is there a way to avoid that?

[sealedtx]

@dspolimi Avoid what? For AudioFormat if mime type contains webm - the extention will be .weba, if mime type contains mp4 - the extenstion will be m4a

java-youtube-downloader/src/main/java/com/github/kiulian/downloader/model/formats/Format.java

Lines 65 to 83 in 6b2f21d

	if (mimeType == null || mimeType.isEmpty()) {
	extension = Extension.UNKNOWN;
	} else if (mimeType.contains(Extension.MPEG4.value())) {
	if (this instanceof AudioFormat)
	extension = Extension.M4A;
	else
	extension = Extension.MPEG4;
	} else if (mimeType.contains(Extension.WEBM.value())) {
	if (this instanceof AudioFormat)
	extension = Extension.WEBA;
	else
	extension = Extension.WEBM;
	} else if (mimeType.contains(Extension.FLV.value())) {
	extension = Extension.FLV;
	} else if (mimeType.contains(Extension._3GP.value())) {
	extension = Extension._3GP;
	} else {
	extension = Extension.UNKNOWN;
	}

[DaveTheMatcher]

@dspolimi Avoid what? For AudioFormat if mime type contains webm - the extention will be .weba, if mime type contains mp4 - the extenstion will be m4a

java-youtube-downloader/src/main/java/com/github/kiulian/downloader/model/formats/Format.java

Lines 65 to 83 in 6b2f21d

	if (mimeType == null || mimeType.isEmpty()) {
	extension = Extension.UNKNOWN;
	} else if (mimeType.contains(Extension.MPEG4.value())) {
	if (this instanceof AudioFormat)
	extension = Extension.M4A;
	else
	extension = Extension.MPEG4;
	} else if (mimeType.contains(Extension.WEBM.value())) {
	if (this instanceof AudioFormat)
	extension = Extension.WEBA;
	else
	extension = Extension.WEBM;
	} else if (mimeType.contains(Extension.FLV.value())) {
	extension = Extension.FLV;
	} else if (mimeType.contains(Extension._3GP.value())) {
	extension = Extension._3GP;
	} else {
	extension = Extension.UNKNOWN;
	}

Thank you for the quick answer.
Is there a way to always download m4a files, or do i have to convert the file?

[sealedtx]

@dspolimi This library does not convert any format itself, it just parses metadata and provide url to formats provided by Youtube. If format is provided with webm format - the file you are going to download is encoded with webm codecs by Youtube and thats how it works. Just select format with extension which suits you.