From 52ee04b6607a89eecc53b09a945aa6aa315a416f Mon Sep 17 00:00:00 2001 From: Michael Noack Date: Thu, 17 May 2018 11:17:20 +0930 Subject: [PATCH] Remove no longer supported Array methods to_param/show_name * Hasn't been used in QuickTravel since 2007 See QT commit:7e27b6a6 ("IT PRINTS") * Hasn't been used in QuickTravel since 2010 See QT commit:b049d91b ("Fixes #1904") --- CHANGELOG.md | 3 +++ lib/ruby_core_extensions/array.rb | 8 -------- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 32a0e4f..6d618f2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,9 @@ This changelog adheres to [Keep a CHANGELOG](http://keepachangelog.com/). ### Added - [TT-4020] Implemented Rubocop +### Removed +- Remove no longer supported Array methods #to_param/#show_name + ### Changed - stringify_values_recursively now just works on to_s for all objects diff --git a/lib/ruby_core_extensions/array.rb b/lib/ruby_core_extensions/array.rb index 9ce4966..2c1aa3d 100644 --- a/lib/ruby_core_extensions/array.rb +++ b/lib/ruby_core_extensions/array.rb @@ -1,12 +1,4 @@ class Array - def to_param - self.collect { |element| element.respond_to?(:to_param) ? element.to_param : element } - end - - def show_name - first.titleize - end - # Key should be unique, or latest element with that key will override previous ones. def hash_by(key = nil, method = nil, &block) self.inject({}) do |h, element|