Skip to content

Conversation

@razor-x
Copy link
Member

@razor-x razor-x commented Jun 25, 2025

  • Hide preamble for resources on secondary route
  • Filter resource samples that don't match filters

@razor-x razor-x marked this pull request as ready for review June 25, 2025 00:37
@razor-x razor-x requested review from a team as code owners June 25, 2025 00:37
@DebbieAtSeam
Copy link
Contributor

@razor-x An excellent step forward! A few things that I noticed...

  • You removed the extra device overview from the thermostats page, but the overview also got removed (incorrectly) from access codes and unmanaged access codes.
  • The alphabetization of the errors on the access code page is weird.

Also posted in Slack, but including here to keep them all together:

  • The first device.properties prop on the thermostats page is an experimental prop that's marked as undocumented in seam-connect.
  • How do I add descriptions for the capability flags?

@razor-x
Copy link
Member Author

razor-x commented Jun 25, 2025

You removed the extra device overview from the thermostats page, but the overview also got removed (incorrectly) from access codes and unmanaged access codes.

@DebbieAtSeam

Will fix this before merge!

The alphabetization of the errors on the access code page is weird.

This is intentional. It's ordered by the parent resource that owns the error first, then the name. This will be addressed in a followup PR that groups the error by the resource. In this PR I mostly wanted to see if I could determine which resource the error was coming from.

The other two items will be answered outside of this PR.

@razor-x razor-x merged commit e689b17 into main Jun 25, 2025
14 checks passed
@razor-x razor-x deleted the evan/cx-385-special-layout-when-using-include_groups branch June 25, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants