You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 15, 2024. It is now read-only.
The Seam makeRequest method ensures consistent behavior when making any http request to the Seam API. The http call in the new public method should use makeRequest. We need to factor out makeRequest to a normal function and call it in both makeRequest and any static methods.
@azat-co I didn't save my comment 😭
Anyway, was just going to say we should make sure to respect axiosOptions, so like in the constructor, something like
Looking closer, I just realized the normal client behavior does a bit more, like always throw SeamAPIError. We should factor out the client creation method and use it both places. I will make an issue for that.
The Seam
makeRequestmethod ensures consistent behavior when making any http request to the Seam API. The http call in the new public method should usemakeRequest. We need to factor outmakeRequestto a normal function and call it in bothmakeRequestand any static methods.Anyway, was just going to say we should make sure to respect
axiosOptions, so like in the constructor, something likeLooking closer, I just realized the normal client behavior does a bit more, like always throw
SeamAPIError. We should factor out the client creation method and use it both places. I will make an issue for that.Originally posted by @razor-x in seamapi/javascript#176 (comment)