This repository was archived by the owner on Nov 15, 2024. It is now read-only.
make browser compatible#173
Merged
Merged
Conversation
…nt variables are not available
codetheweb
approved these changes
Mar 29, 2023
razor-x
reviewed
Mar 29, 2023
| endpoint: process?.env?.SEAM_API_URL || "https://connect.getseam.com", | ||
| workspaceId: process?.env?.SEAM_WORKSPACE_ID, | ||
| } | ||
| } catch (error) { |
Member
There was a problem hiding this comment.
How do we know we are in browser? Can we check for process.env instead of catching all errors, like globalThis?.process?.env == null
Contributor
Author
There was a problem hiding this comment.
@razor-x we had process? and it was failing miserably crashing the whole app... same for if (!process) maybe something else was causing the crashes (see logs attached)
maybe there's a better way but try catch works for now.
Member
There was a problem hiding this comment.
I think globalThis is the intended solution for this. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis
Contributor
|
🎉 This PR is included in version 5.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 fix(client.ts): handle case when running in a browser and environment variables are not available