This repository was archived by the owner on Nov 15, 2024. It is now read-only.
Improvements to client session methods #191
Merged
Merged
Conversation
razor-x
force-pushed
the
cleanup-get-client-session
branch
from
69c92b6 to
fc21ce2
Compare
razor-x
force-pushed
the
cleanup-get-client-session
branch
from
fc21ce2 to
8a26dd7
Compare
seveibar
reviewed
May 2, 2023
| getSeamClientOptionsWithDefaults(ops) | ||
| let headers: AxiosRequestHeaders = { | ||
| const headers = { | ||
| "seam-user-identifier-key": options.userIdentifierKey, |
Contributor
There was a problem hiding this comment.
not opposed to this header, but i think i lean towards this being preferred in the payload, allowed in header/. headers distract from the concept that we're basically an RPC API, we only use them where convention or security pushes us to. That being said, I think it's ok that it's accepted as a header.
Member
Author
There was a problem hiding this comment.
I think this is the existing implementation (not added in this PR). We can make the switch but will need to check the endpoint first to see if it will accept this in the body.
seveibar
approved these changes
May 2, 2023
Contributor
|
🎉 This PR is included in version 5.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.