Skip to content

fix: offline lock device missing details #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 16, 2025
Merged

fix: offline lock device missing details #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b1e6c52
fix: offline lock device missing details
mikewuu Oct 16, 2025
a65d661
ci: Format code
seambot Oct 16, 2025
55fc5c2
Merge branch 'main' into missing-device-details
mikewuu Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/lib/seam/components/DeviceDetails/LockDeviceDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,7 @@ export function LockDeviceDetails({
const [snackbarVariant, setSnackbarVariant] =
useState<SnackbarVariant>('success')

const accessCodeCount = accessCodes?.length

if (accessCodes == null) {
return null
}
const accessCodeCount = accessCodes?.length ?? 0

if (accessCodesOpen) {
return (
Expand Down Expand Up @@ -137,13 +133,15 @@ export function LockDeviceDetails({
</div>
<div className='seam-box'>
<div
className='seam-content seam-access-codes'
onClick={toggleAccessCodesOpen}
className={classNames('seam-content seam-access-codes', {
disabled: accessCodes == null,
})}
onClick={accessCodes != null ? toggleAccessCodesOpen : undefined}
>
<span className='seam-value'>
{accessCodeCount} {t.accessCodes}
{accessCodes != null ? accessCodeCount : '–'} {t.accessCodes}
</span>
<ChevronRightIcon />
{accessCodes != null && <ChevronRightIcon />}
</div>
</div>

Expand Down
5 changes: 5 additions & 0 deletions src/styles/_device-details.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@
justify-content: space-between;
cursor: pointer;

&.disabled {
opacity: 0.6;
cursor: not-allowed;
}

&:hover {
background: colors.$item-hover-bg;
}
Expand Down
Loading