New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put tools.deps in a pod? #5

Closed
martinklepsch opened this Issue Dec 12, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@martinklepsch

martinklepsch commented Dec 12, 2017

Not sure if this is worth it or even possible but could we put the tools.deps machinery into a pod?

Leaving this here for later consideration.

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Dec 12, 2017

Owner

I think a pod is overkill for the general case -- a Boot pipeline that wants to get dependencies via tools.deps instead of hardcoded into build.boot, which includes the command-line only case (no build.boot) -- but for a build.boot file already leveraging pods, it makes sense to be able to run this all inside a pod.

I think a pre-req for that is splitting load-deps in two: a function that calls into tools.deps and merges all the deps.edn stuff and returns the paths and dependencies as data, and then load-deps could just merge that data into the (global) environment.

Then move the loading of tools.deps into a function and making the use of tools.deps dynamic (I tried this originally and it defeated me -- I do not want to be forced into a pod in all cases -- so it just needs more time spent on solving it).

Finally those can be recombined for the case of building a pod based on deps.edn files.

Owner

seancorfield commented Dec 12, 2017

I think a pod is overkill for the general case -- a Boot pipeline that wants to get dependencies via tools.deps instead of hardcoded into build.boot, which includes the command-line only case (no build.boot) -- but for a build.boot file already leveraging pods, it makes sense to be able to run this all inside a pod.

I think a pre-req for that is splitting load-deps in two: a function that calls into tools.deps and merges all the deps.edn stuff and returns the paths and dependencies as data, and then load-deps could just merge that data into the (global) environment.

Then move the loading of tools.deps into a function and making the use of tools.deps dynamic (I tried this originally and it defeated me -- I do not want to be forced into a pod in all cases -- so it just needs more time spent on solving it).

Finally those can be recombined for the case of building a pod based on deps.edn files.

@seancorfield

This comment has been minimized.

Show comment
Hide comment
@seancorfield

seancorfield Jan 28, 2018

Owner

Fixed in 0.2.0!

Owner

seancorfield commented Jan 28, 2018

Fixed in 0.2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment