Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider whether this should live in Contrib or not #3

Closed
seancorfield opened this issue Apr 1, 2019 · 2 comments

Comments

Projects
None yet
1 participant
@seancorfield
Copy link
Owner

commented Apr 1, 2019

A pro for Contrib would be that the existing clojure.java.jdbc implementation could be updated to use the new, faster implementation (Contrib libs should not depend on external libraries). It's an open question as to whether that is worth doing (there may be some sharp edges trying to fit the two together, especially where deliberate API changes have been made in next.jdbc).

@seancorfield

This comment has been minimized.

Copy link
Owner Author

commented Apr 18, 2019

This page outlines what Contrib libs are and what their benefits are: https://clojure.org/community/contrib_libs

  • Source control - Git libraries on GitHub
  • Issues - JIRA
  • Development model - patches in JIRA, no PRs
  • Continuous integration - Jenkins
  • Doc generation and hosting - Autodoc and GitHub pages
  • Builds - Maven with deployment to Maven Central under the groupId org.clojure

In addition, I think the org.clojure group ID and the presence of documentation on clojure.github.io provide some boost to the visibility/reach of a library.

@seancorfield

This comment has been minimized.

Copy link
Owner Author

commented May 22, 2019

As it stands, next.jdbc has:

  • Source control - Git library on GitHub
  • Issues - GitHub
  • Development model - issues and PRs in GitHub
  • Continuous integration - CircleCI (without building artifacts)
  • Builds - manual to Clojars under the group ID seancorfield

Documentation is auto-generated on https://cljdoc.org/d/seancorfield/next.jdbc/

Only the "authority" / "visibility" of the clojure org on GitHub and the org.clojure group ID have been given up and I now feel that's less valuable than I had initially thought based on some feedback from other Clojurians.

seancorfield added a commit that referenced this issue May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.