- add deprecated versions of OCArgumentVariable and OCTempVariable

- do not use #isLocal in Slot but instead implement isDefinedByOwningClass

I have not changed the senders of #isLocalVariable as maybe on the level of the Variables, we could keep the isXVariable checks... I guess we will get a better feel for that when we unify
with the node level.

src/Deprecated90/OCArgumentVariable.class.st

@@ -0,0 +1,5 @@
+Class {
+	#name : #OCArgumentVariable,
+	#superclass : #ArgumentVariable,
+	#category : #'Deprecated90-OpalCompiler-Core'
+}

src/Deprecated90/OCTempVariable.class.st

@@ -0,0 +1,5 @@
+Class {
+	#name : #OCTempVariable,
+	#superclass : #TemporaryVariable,
+	#category : #'Deprecated90-OpalCompiler-Core'
+}

src/Kernel/ClassDescription.class.st

@@ -875,7 +875,7 @@ ClassDescription >> linesOfCode [
 { #category : #slots }
 ClassDescription >> localSlots [
 
-	^ self slots select: [ :aSlot | aSlot isLocal ]
+	^ self slots select: [ :aSlot | aSlot isDefinedByOwningClass ]
 ]
 
 { #category : #'accessing tags' }

src/Kernel/Slot.class.st

@@ -212,14 +212,14 @@ Slot >> isAccessedIn: aCompiledCode [
 ]
 
 { #category : #testing }
-Slot >> isInstance [
-	^ true
+Slot >> isDefinedByOwningClass [
+
+	^ self owningClass = self definingClass
 ]
 
 { #category : #testing }
-Slot >> isLocal [
-
-	^ self owningClass = self definingClass
+Slot >> isInstance [
+	^ true
 ]
 
 { #category : #testing }

src/Kernel/Variable.class.st

@@ -124,6 +124,11 @@ Variable >> isLiteralVariable [
 	^false
 ]
 
+{ #category : #testing }
+Variable >> isLocal [
+	^false
+]
+
 { #category : #testing }
 Variable >> isLocalVariable [
 	^false

src/Shift-ClassBuilder/ShLayoutDefinition.class.st

@@ -59,7 +59,7 @@ ShLayoutDefinition >> copy: slotCollection ifUsedIn: aClass [
 ShLayoutDefinition >> copyClassSlotsIfNeeded: oldSlots [ 
 
 	classSlots ifNotNil: [ ^ self ].
-	classSlots := (oldSlots select: #isLocal thenCollect: [ :e | e copy index: nil; yourself ])
+	classSlots := (oldSlots select: #isDefinedByOwningClass thenCollect: [ :e | e copy index: nil; yourself ])
 ]
 
 { #category : #accessing }